Set action name to /ns/pkg/action just like the real thing #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the way the action name is set by aligning the format with the Runtime, ensuring that it follows the "/ns/pkg/action" pattern.
- Updated the __OW_ACTION_NAME environment variable to include the namespace, package name, and action name.
- Standardized the action name format to mirror the live runtime behavior.
Comments suppressed due to low confidence (1)
src/lib/run-dev.js:364
- [nitpick] Consider verifying that process.env.__OW_NAMESPACE does not already include a leading slash to avoid duplicating slashes in the resulting action name.
process.env.__OW_ACTION_NAME = `/${process.env.__OW_NAMESPACE}/${packageName}/${actionName}`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 642 642
Branches 132 132
=========================================
Hits 642 642 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pru55e11
approved these changes
May 20, 2025
sandeep-paliwal
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were setting action name differently from Runtime.
Proper format is /ns/pkg/action
Related Issue
adobe/aio-cli#752
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: